On Fri, Apr 2, 2010 at 12:43 PM, FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx> wrote: > On Fri, 2 Apr 2010 12:27:34 +1100 > ronnie sahlberg <ronniesahlberg@xxxxxxxxx> wrote: > >> Metadata is a different topic. As you say, xattr is difficult to use >> in a unified way to store things because of SSC requiring so much >> metadata. >> I will leave metadata in targets.conf for now until there is consensus >> on how to handle it in an acceptable way for MMC and SBC. >> Perhaps one could use *.tgtd-metadata files to store the metadata for >> MMC and SBC devices isntead of xattr? > > The idea to use a separate file for metadata was discussed too with > ssc but we already have targets.conf and can store some metadata in > it. Seems that it doesn't make sense much to have another separate > metadata files. > I know and I remember the discussion. For now, lets put the metadata storage discussion to the side and for later. This patch is a trivial patch that just makes tgtimg create an empty file to be used for dvd+r burnable media. This can most definitely be done just as well with "touch file", but doing it with tgtimg offers two small benefits 1, using the same command to create MMC devices as SSC devices, eventhough the command is a trivial reimplementation of "touch" 2, allows a natural place in the manpages to describe how to create MMC device image files. While trivial, 2 I think is a strong benefit. It makes it easier for the user browsing manpages to find out how to create a image file for MMC instead of looking into /usr/share/doc/tgt/README.mmc Similarly to add a later patch to use tgtimg to create a DISK image. Which would really just be a reimplementation of dd if=/dev/zero of=<file) but more userfriendly and documented in the tgtimg manpage. What drives me here is my opinion : "if its not in the manpage, it doesnt exist". So I wont add any xattr or other metadata changes to tgtimg, but would these trivial changes to tgtimg to create, and document,.mmc and sbc image files be acceptable? regards ronnie sahlberg -- To unsubscribe from this list: send the line "unsubscribe stgt" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
