On Wed, 24 Mar 2010 12:48:03 +0100 Tomasz Chmielewski <mangoo@xxxxxxxx> wrote: > Am 24.03.2010 12:15, Tomasz Chmielewski wrote: > > > Does it always accept one value, or is it allowed to use more values? Say: > > > > tgtadm --op update --mode sys --name iSNSServerIP -v 192.168.11.133 > > tgtadm --op update --mode sys --name iSNSServerIP -v 192.168.22.233 > > tgtadm --op update --mode sys --name iSNSServerIP -v 192.168.33.33 > > Looks iSNSServerIP will be updated each time with commands above. Yeah, we have the only one iSNS server. Mike, do we need to support multiple iSNS servers? I completely forgot about iSNS stuff. :) > Some more questions: > > > 1) README.iscsi states: > > "once you enable iSNS, you can't disable it". > > What about updating iSNS* parameters - is it allowed to change them once > iSNS has been enabled (i.e. will updating iSNS* parameters have any effect)? No effect. > 2) with 1.0.3, I did: > > # tgtd > tgtadm --op update --mode sys --name iSNSAccessControl -v On > tgtadm --op update --mode sys --name iSNSServerIP -v 192.168.111.177 > tgtadm --op update --mode sys --name iSNSServerPort -v 2342 > tgtadm --op update --mode sys --name iSNS -v On > > > Here, iSNSAccessControl shows "Off" - is it expected? Oops, it's a bug. I've attached a fix. Thanks a lot! = From: FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx> Subject: [PATCH] isns: fix the port configuration Signed-off-by: FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx> --- usr/iscsi/isns.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/usr/iscsi/isns.c b/usr/iscsi/isns.c index c4d90cf..f228112 100644 --- a/usr/iscsi/isns.c +++ b/usr/iscsi/isns.c @@ -1027,6 +1027,7 @@ int isns_update(char *params) case Opt_port: if (match_int(&args[0], &isns_port)) ret = TGTADM_INVALID_REQUEST; + break; case Opt_ac: match_strncpy(tmp, &args[0], sizeof(tmp)); use_isns_ac = !strcmp(tmp, "On"); -- 1.6.5 -- To unsubscribe from this list: send the line "unsubscribe stgt" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
