Re: [PATCH] Get "make tarball" working on legacy platforms

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue,  6 Oct 2009 12:44:13 +0200
Florian Haas <florian.haas@xxxxxxxxxx> wrote:

> Here's one thing I missed while testing my Makefile patches: some
> older platforms, notably CentOS 5.3, come with a tar utility that
> misses the --transform option, so "make tarball" breaks on those. This
> patch changes the tarball target so it can do without transform. It
> does a rather ugly cp -r now, though.
> 
> Sorry for not noticing this sooner.
> 
> Cheers,
> Florian
> 
> Florian Haas (1):
>   Top-level Makefile: do not use --transform when invoking tar
> 
>  Makefile |    7 +++++--
>  1 files changed, 5 insertions(+), 2 deletions(-)

I'm not sure if `make tarball` is useful. I don't use it so it's not
my problem but I don't want to support something that doesn't work
well.

For example, `make tarball` creates useless tarball for me:

fujita@viola:~/git/tgt$ tar tjf tgt-0.9.9.tar.bz2 |head
tgt-0.9.9/GPATH
tgt-0.9.9/GRTAGS
tgt-0.9.9/GSYMS
tgt-0.9.9/GTAGS
tgt-0.9.9/Makefile
tgt-0.9.9/README
tgt-0.9.9/conf/
tgt-0.9.9/conf/targets.conf


Everyone has other files for other reasons. I don't think that `make
tarball` is a good idea.

You complained that git-archive handles only files in a git tree but
it should not be a problem. You have your own git tree so git-archive
should create a nice tarball for you.
--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux SCSI]     [Linux RAID]     [Linux Clusters]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]

  Powered by Linux