Re: [PATCH 2/2] tgt-admin: check if device is mounted on /

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



FUJITA Tomonori schrieb:
On Thu, 11 Sep 2008 17:33:14 +0300
Doron Shoham <dorons@xxxxxxxxxxxx> wrote:

deny allocation of a device which
mounted on the same device as rootfs.
also deny the allocation of swap devices.
using --force flag for overriding this.

Signed-off-by: Doron Shoham <dorons@xxxxxxxxxxxx>
---
 scripts/tgt-admin |   87 +++++++++++++++++++++++++++++++++++++++++++++++++----

Thanks, sounds good. Any objection against this patch?

I'm still not persuaded that it's the right approach.

I.e., let's say we have a device which is always in use, but we want tgtd to use it.

With current approach, we have to start tgt-admin several times:

1) Lets start all targets:

# tgt-admin -e -v
Adding targets...
Skipping device /dev/blah, is in use...

2) Configure the device once again, with --force:
# tgt-admin --update iqn.2008-08.com.example:some.target --force


It is not very user-friendly.

Therefore, an option in the config file would be great, like:

	allow-in-use yes


--
Tomasz Chmielewski
http://wpkg.org
--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux SCSI]     [Linux RAID]     [Linux Clusters]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]

  Powered by Linux