Re: [PATCH v2 2/2] staging: rtl8712: Calculate size from pointer

[Philipp Hortmann <philipp.g.hortmann@xxxxxxxxx>]

On 8/28/24 22:45, Manisha Singh wrote:
> Calculate the size from the pointer instead of struct
Hi Manisha,

the first line of the description is good. Please just add the why (to 
adhere to kernel coding style?) and the "." to make it a full sentence.

Omit the next two lines.
> CHECK: Prefer kmalloc(sizeof(*pintf_hdl->pintfpriv)...) over
> kmalloc(sizeof(struct intf_priv)...)

Thanks for your support.

Bye Philipp

> Signed-off-by: Manisha Singh <masingh.linux@xxxxxxxxx>
> ---
>   drivers/staging/rtl8712/rtl871x_io.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8712/rtl871x_io.c b/drivers/staging/rtl8712/rtl871x_io.c
> index 6311ac15c581..8ad4647dad2f 100644
> --- a/drivers/staging/rtl8712/rtl871x_io.c
> +++ b/drivers/staging/rtl8712/rtl871x_io.c
> @@ -48,7 +48,7 @@ static uint _init_intf_hdl(struct _adapter *padapter,
>   	set_intf_funs = &(r8712_usb_set_intf_funs);
>   	set_intf_ops = &r8712_usb_set_intf_ops;
>   	init_intf_priv = &r8712_usb_init_intf_priv;
> -	pintf_priv = kmalloc(sizeof(struct intf_priv), GFP_ATOMIC);
> +	pintf_priv = kmalloc(sizeof(*pintf_priv), GFP_ATOMIC);
>   	if (!pintf_priv)
>   		goto _init_intf_hdl_fail;
>   	pintf_hdl->pintfpriv = pintf_priv;