On Fri, Aug 16, 2024 at 04:04:38PM +0300, Dan Carpenter wrote:
> On Fri, Aug 16, 2024 at 05:51:32AM -0700, Changhuang Liang wrote:
> > Add the dynamic resolution support for video "capture_raw" device.
> >
>
> What does this change look like from a use perspective if a user is reading the
> git log?
>
> > Fixes: e080f339c80a ("media: staging: media: starfive: camss: Add capture driver")
> >
>
> This looks like a new feature and not a bugfix. Please describe the bug more
> clearly if it's really a bugfix.
>
Actually the first version of the commit had a good description. Just go back
to that.
> Add multiple resolution support for video "capture_raw" device. Otherwise
> it will capture the wrong image data if the width is not 1920.
Btw:
1) Don't put a blank line after the Fixes tag.
2) Put a note under the --- cut off line that says what changed.
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
Please send v3.
regards,
dan carpenter
