On 7/30/24 10:05, Santiago Ruano Rincón wrote:
Fix checkpatch error "ERROR: code indent should use tabs where possible"
in include/rtw_mlme_ext.h:388.
Signed-off-by: Santiago Ruano Rincón <santiagorr@xxxxxxxxxx>
---
I am (mostly) a newcommer. Could you please tell me if there is anything
wrong with this patch? Thank you!
checkpatch reports a warning in line 387:
"WARNING: line length of 135 exceeds 100 columns"
Should I fix the warning in the same patch, or should I send a second
patch to fix it?
---
---
drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h b/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h
index 5b8574f5a..720aeeb00 100644
--- a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h
+++ b/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h
@@ -384,8 +384,8 @@ struct mlme_ext_priv {
unsigned char default_supported_mcs_set[16];
struct ss_res sitesurvey_res;
- struct mlme_ext_info mlmext_info;/* for sta/adhoc mode, including current scanning/connecting/connected related info. */
- /* for ap mode, network includes ap's cap_info */
+ struct mlme_ext_info mlmext_info; /* for sta/adhoc mode, including current scanning/connecting/connected related info. */
+ /* for ap mode, network includes ap's cap_info */
struct timer_list survey_timer;
struct timer_list link_timer;
struct timer_list sa_query_timer;
Hi Santiago,
it could be two patches or one. You are only allowed to do one thing at
a time. So it is also a little depending on your description. The way
you describe this it is more like two patches.
If your description would be like:
Insert line break to comment, that exceeds 100 columns, to improve
readability.
It would be OK to correct the indent as well.
If you send in a second version of this patch please use a change
history. Description from Dan under:
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
In case of questions feel free to contact me directly.
Thanks for your support.
Bye Philipp
