On 7/30/24 17:50, Manjae Cho wrote:
This patch improves the usage of the MAR register by updating the
relevant
macro definitions and ensuring consistent usage across the codebase.
Signed-off-by: Manjae Cho <manjae.cho@xxxxxxxxxxx>
---
drivers/staging/rtl8723bs/hal/sdio_halinit.c | 4 ++--
drivers/staging/rtl8723bs/include/hal_com_reg.h | 3 +++
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
index c9cd6578f7f8..9493562c1619 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
@@ -380,8 +380,8 @@ static void _InitWMACSetting(struct adapter *padapter)
rtw_write32(padapter, REG_RCR, pHalData->ReceiveConfig);
/* Accept all multicast address */
- rtw_write32(padapter, REG_MAR, 0xFFFFFFFF);
- rtw_write32(padapter, REG_MAR + 4, 0xFFFFFFFF);
+ rtw_write32(padapter, MAR0, 0xFFFFFFFF);
+ rtw_write32(padapter, MAR4, 0xFFFFFFFF);
/* Accept all data frames */
value16 = 0xFFFF;
diff --git a/drivers/staging/rtl8723bs/include/hal_com_reg.h b/drivers/staging/rtl8723bs/include/hal_com_reg.h
index 9a02ae69d7a4..baf326d53a46 100644
--- a/drivers/staging/rtl8723bs/include/hal_com_reg.h
+++ b/drivers/staging/rtl8723bs/include/hal_com_reg.h
@@ -151,6 +151,9 @@
#define REG_BSSID 0x0618
#define REG_MAR 0x0620
+#define MAR0 REG_MAR /* Multicast Address Register, Offset 0x0620-0x0623 */
+#define MAR4 (REG_MAR + 4) /* Multicast Address Register, Offset 0x0624-0x0627 */
+
#define REG_MAC_SPEC_SIFS 0x063A
/* 20100719 Joseph: Hardware register definition change. (HW datasheet v54) */
#define REG_RESP_SIFS_CCK 0x063C /* [15:8]SIFS_R2T_OFDM, [7:0]SIFS_R2T_CCK */
Hi Manjae,
please start your Subject according to the expected standard:
staging: rtl8723bs:
The description seems to have a line break that should not be there.
please use checkpatch for your patches:
File Nr: 0 Patch: ../../../Downloads/20240730-[PATCH] Improve MAR
register definition and usage -17243.txt
WARNING: line length of 126 exceeds 100 columns
#41: FILE: drivers/staging/rtl8723bs/include/hal_com_reg.h:154:
+#define MAR0 REG_MAR /* Multicast Address Register, Offset
0x0620-0x0623 */
WARNING: line length of 126 exceeds 100 columns
#42: FILE: drivers/staging/rtl8723bs/include/hal_com_reg.h:155:
+#define MAR4 (REG_MAR + 4) /* Multicast Address Register, Offset
0x0624-0x0627 */
If you send in a second version of this patch please use a change
history. Description from Dan under:
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
In case of questions feel free to contact me directly.
Thanks for your support.
Bye Philipp
