On Sun, Jul 21, 2024 at 2:07 PM Nam Cao <namcao@xxxxxxxxxxxxx> wrote: > > On Sun, Jul 21, 2024 at 01:43:37PM +0900, 문연수 wrote: > > 2024년 7월 21일 (일) 오후 1:06, Moon Yeounsu <yyyynoom@xxxxxxxxx>님이 작성: > > > From: Moon Yeounsu <yyyynoom@xxxxxxxxx> > > > > > > It fix the following checkpatch.pl warning: > > > Avoid multiple line dereference - prefer %s > > > > > > Suggested-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > > Signed-off-by: Moon Yeounsu <yyyynoom@xxxxxxxxx> > > > --- > > > v2: Fix email address and checkpatch.pl warning > > > v3: Fix incorrect commit index, start with new thread for new version of patch, > > > place notes below the cutoff line, provide appropriate CC, > > > include 'Suggested-by' sign for those who gives good guideline. > > The "Suggested-by:" thingy is for patch idea, not for "guideline". Have a > look at Documentation/process/submitting-patches.rst. Then, I think "Suggested-by" have to be inserted. There are some misleading by my poor english skill. He literally gave me a "patch idea", not a "guideline". Reference: https://lore.kernel.org/linux-staging/20240718132607.13634-1-yyyynoom@xxxxxxxxx/T/#m631c138006ea7e834d6ab4c950cf00f1a0d0e3e3 > > ... > > Sorry and thank you to all of the reviewers and maintainers who take > > care of my patch. > > I make a new problem... I think I check my patch and email over and > > over and over. > > but, again, I sent the patch incorrectly. The body of the patch > > contains improper content, > > and also sends the email as my nickname, not a real name. > > > > Sorry for making spam and taking your invaluable time. > > Next time, I'll send a right and valuable patch. > > Oh no worry, I'm sure people are happy to help. Linux's email-based > workflow is not the easiest to get right. > > If you worry about "making spam", you could send the patch to yourself and > try "git am" the email. If it works then send it out for real. Why didn't I think of that? It is a brilliant idea in order to double-check patch and email. Thank you for your advice! I'll do so. > > Good luck, > Nam
