Re: [PATCH v3] staging: rtl8712: style fix multiple line dereference

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2024년 7월 21일 (일) 오후 1:06, Moon Yeounsu <yyyynoom@xxxxxxxxx>님이 작성:
>
> From: Moon Yeounsu <yyyynoom@xxxxxxxxx>
>
> It fix the following checkpatch.pl warning:
> Avoid multiple line dereference - prefer %s
>
> Suggested-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Signed-off-by: Moon Yeounsu <yyyynoom@xxxxxxxxx>
> ---
> v2: Fix email address and checkpatch.pl warning
> v3: Fix incorrect commit index, start with new thread for new version of patch,
>         place notes below the cutoff line, provide appropriate CC,
>         include 'Suggested-by' sign for those who gives good guideline.
>
>  drivers/staging/rtl8712/rtl871x_cmd.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
> index bbd4a13c7bb9..ffeb91dd28c4 100644
> --- a/drivers/staging/rtl8712/rtl871x_cmd.c
> +++ b/drivers/staging/rtl8712/rtl871x_cmd.c
> @@ -528,8 +528,9 @@ void r8712_setstakey_cmd(struct _adapter *padapter, u8 *psta, u8 unicast_key)
>         if (unicast_key)
>                 memcpy(&psetstakey_para->key, &sta->x_UncstKey, 16);
>         else
> -               memcpy(&psetstakey_para->key, &psecuritypriv->XGrpKey[psecuritypriv->XGrpKeyid - 1].
> -                      skey, 16);
> +               memcpy(&psetstakey_para->key,
> +                      &psecuritypriv->XGrpKey[psecuritypriv->XGrpKeyid - 1].skey,
> +                      16);
>         r8712_enqueue_cmd(pcmdpriv, ph2c);
>  }
> --
> 2.43.5
>

Sorry and thank you to all of the reviewers and maintainers who take
care of my patch.
I make a new problem... I think I check my patch and email over and
over and over.
but, again, I sent the patch incorrectly. The body of the patch
contains improper content,
and also sends the email as my nickname, not a real name.

Sorry for making spam and taking your invaluable time.
Next time, I'll send a right and valuable patch.





[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux