Re: [PATCH 1/2] staging: pi433: Use class_create instead of class_register.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/05/2024 17:14, Greg KH wrote:
On Wed, May 01, 2024 at 05:00:44PM +0300, Dan Carpenter wrote:
On Wed, May 01, 2024 at 08:58:19AM +0300, Shahar Avidar wrote:
Make use of a higher level API.
Reduce global memory allocation from struct class to pointer size.

Doesn't this move the memory in the opposite direction from what we
want?  Originally, it's static const.  Isn't that the simplest best
kind of memory?

Our reviews just crossed...  This is just a revert (in 2 steps oddly),
of a previous commit that changed this api call, and for that reason
alone we can't take it :)

Thank you for your input.
I replied to Greg's review on another thread.
I won't pursue this change.

--
Regards,

Shahar





[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux