On Wed, May 01, 2024 at 08:58:19AM +0300, Shahar Avidar wrote: > Make use of a higher level API. What does this mean? > Reduce global memory allocation from struct class to pointer size. No, you increased memory allocation here, why do you think you reduced it? Also, this looks like a revert of commit f267da65bb6b ("staging: pi433: make pi433_class constant"), accepted a few months ago, why not just call it out as an explicit revert if that's what you want to do? class_create is going away "soon", why add this back when people are working so hard to remove its usage? What tutorial did you read that made you want to make this change? thanks, greg k-h