On Tue, Apr 16, 2024 at 05:50:34PM +0300, Andy Shevchenko wrote: > On Tue, Apr 16, 2024 at 03:40:43PM +0100, Kieran Bingham wrote: ... > Thanks for playing with this. > > The issue with the original code is readability and potential oddity about > boolean to integer conversion. That said, I prefer my variant for the sake > of clarity. Hans, in case you are going to update your PR once again, I still think the LM3554 driver removal commit message may be improved by pointing out to the existing driver. -- With Best Regards, Andy Shevchenko