Re: [PATCH 11/23] media: atomisp: Remove test pattern generator (TPG) support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 16, 2024 at 12:25 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
> On 4/15/24 4:40 PM, Andy Shevchenko wrote:
> > On Mon, Apr 15, 2024 at 02:02:08PM +0200, Hans de Goede wrote:

...

> >>              unsigned int hblank_cycles = 100,
> >>              vblank_lines = 6,
> >>              width,
> >
> > Urgh... These comma operators probably is subject to replace with separate
> > definitions or being grouped on a single line (as it suppose to be in this
> > case).
>
> That indeed is ugly, but fixing this is out of scope for this patch,
> so I've added an extra patch to the set to address this:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git/commit/?h=media-atomisp&id=48d93af9d9b0fd40a21a656cb8cd8e25700bfed5

WFM, thanks!

Btw (yes, I see you tagged that already, so just FYI then)
(1 + (stream->config.pixels_per_clock == 2));
is an interesting way of using

 (stream->config.pixels_per_clock == 2) ? 2 : 1);

which likely can produce slightly better code (due to use of constant
2 twice), although it is a pure speculation by me.

-- 
With Best Regards,
Andy Shevchenko





[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux