Re: [PATCH] Staging : ks7010 ks_wlan_net : Fixed Unnecessary Paranthesis, Prefer Fallthrough and Line spacing issue.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Karan Sanghavi <karansanghvi98@xxxxxxxxx>
Subject: Re: [PATCH] Staging : ks7010 ks_wlan_net : Fixed Unnecessary Paranthesis, Prefer Fallthrough and Line spacing issue.
From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Date: Tue, 16 Apr 2024 15:38:49 +0300
Cc: gregkh@xxxxxxxxxxxxxxxxxxx, linux-staging@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20240416115903.92706-1-karansanghvi98@gmail.com>
References: <20240416115903.92706-1-karansanghvi98@gmail.com>

On Tue, Apr 16, 2024 at 05:29:03PM +0530, Karan Sanghavi wrote:
> Fixed a coding style issue.
> 
> Signed-off-by: Karan Sanghavi <karansanghvi98@xxxxxxxxx>

Greg likes parentheses so leave those alone.  The other changes are
wrong and also break the build.

regards,
dan carpenter

References:
- [PATCH] Staging : ks7010 ks_wlan_net : Fixed Unnecessary Paranthesis, Prefer Fallthrough and Line spacing issue.
  - From: Karan Sanghavi

Prev by Date: [PATCH] Staging : ks7010 ks_wlan_net : Fixed Unnecessary Paranthesis, Prefer Fallthrough and Line spacing issue.
Next by Date: Re: [PATCH 11/23] media: atomisp: Remove test pattern generator (TPG) support
Previous by thread: [PATCH] Staging : ks7010 ks_wlan_net : Fixed Unnecessary Paranthesis, Prefer Fallthrough and Line spacing issue.
Index(es):
- Date
- Thread

[Index of Archives] [Linux Driver Development] [Linux Driver Backports] [DMA Engine] [Linux GPIO] [Linux SPI] [Video for Linux] [Linux USB Devel] [Linux Coverity] [Linux Audio Users] [Linux Kernel] [Linux SCSI] [Yosemite Backpacking]

Powered by Linux