On Thu, Mar 14, 2024 at 02:51:19PM +0000, Kieran Bingham wrote:
> Quoting Umang Jain (2024-03-14 10:06:05)
> > The cache-line-size is cached in struct vchiq_drvdata.
> > There is no need to cache this again via g_cache_line_size
> > and use it. Instead use the value from vchiq_drvdata directly.
> >
> > Signed-off-by: Umang Jain <umang.jain@xxxxxxxxxxxxxxxx>
> > ---
> > .../interface/vchiq_arm/vchiq_arm.c | 50 +++++++++++--------
> > 1 file changed, 30 insertions(+), 20 deletions(-)
> >
> > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> > index 8c7520dee5f4..282f83b335d4 100644
> > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> > @@ -71,6 +71,16 @@ static struct vchiq_device *bcm2835_audio;
> > static struct vchiq_device *bcm2835_camera;
> >
> > static struct vchiq_drvdata bcm2835_drvdata = {
> > + /* This value is the size of the L2 cache lines as understood by the
>
> This file has a mix of A)
> /* bulk multiline
> * comments like this
> */
>
>
> and B)
> /*
> * Bulk multiline
> * comments like this
> */
>
> I'd probably use B) when moving this, but again, no point for a respin
> just for that. Only if there's another revision. Or a patch on top to
> normalise throughout if you felt like it, as this is only a move anyway.
Yeah. It should be B. A is only for in networking. But we can change
it later.
regards,
dan carpenter
