On Thu, Mar 14, 2024 at 10:37:29AM +0300, Dan Carpenter wrote: > On Wed, Mar 13, 2024 at 07:32:20PM -0700, Alison Schofield wrote: > > On Wed, Mar 13, 2024 at 11:51:22PM +0530, Ayush Tiwari wrote: > > > This patch adds descriptive comment to mutex within the struct > > > gbaudio_codec_info to clarify its intended use and to address > > > checkpatch checks. > > > > Hi Ayush- > > > > You may be right, but you need to convince your patch reviewers > > why your comment accurately describes this mutex. > > > > That's always the ask with this kind of patch. > > Heh. Yeah. The comment wasn't right in this case. The lock has > nothing to do with registers or register access. > > > > > BTW - Don't start your commit log with 'This patch...'. > > > > Outreachy folk are a more particular about some of this stuff than I am. > Which is fine. Could you do me a favor though? Could you ack patches > once you're happy with them? Dan - Sure. In practice, the patches are often 'Reviewed-by' someone else by the time I get back around to it (thanks to the different time zones and plentiful reviewers) But I understand, I'll make it a habit of at Ack'ing after I've asked for something to change. Alison > > regards, > dan carpenter >
