Hi, Uwe Thanks for your patch. > [PATCH] media: staging: media: starfive: camss: Convert to platform > remove callback returning void > > The .remove() callback for a platform driver returns an int which makes many > driver authors wrongly assume it's possible to do error handling by returning > an error code. However the value returned is ignored (apart from emitting a > warning) and this typically results in resource leaks. > > To improve here there is a quest to make the remove callback return void. In > the first step of this quest all drivers are converted to .remove_new(), which > already returns void. Eventually after all drivers are converted, .remove_new() > will be renamed to .remove(). > > Trivially convert this driver from always returning zero in the remove callback > to the void returning variant. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > --- > drivers/staging/media/starfive/camss/stf-camss.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/media/starfive/camss/stf-camss.c > b/drivers/staging/media/starfive/camss/stf-camss.c > index a587f860101a..f9613c2c9dfe 100644 > --- a/drivers/staging/media/starfive/camss/stf-camss.c > +++ b/drivers/staging/media/starfive/camss/stf-camss.c > @@ -355,7 +355,7 @@ static int stfcamss_probe(struct platform_device > *pdev) > * > * Always returns 0. The annotation from here can be removed. Reviewed-by: Changhuang Liang <changhuang.liang@xxxxxxxxxxxxxxxx> Regards, Changhuang
