Hi Dan,
On 11/2/23 15:35, Dan Carpenter wrote:
> On Thu, Nov 02, 2023 at 05:11:32PM +0300, Alexandra Diupina wrote:
>> media_entity_pads_init() will not return 0 only if the
>> 2nd parameter >= MEDIA_ENTITY_MAX_PADS (512), but 1 is
>> passed, so checking the return value is redundant
>>
>> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>>
>> Fixes: ad85094b293e ("Revert "media: staging: atomisp: Remove driver"")
>> Signed-off-by: Alexandra Diupina <adiupina@xxxxxxxxxxxxx>
>> ---
>> drivers/staging/media/atomisp/i2c/atomisp-gc2235.c | 4 +---
>> drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c | 6 +-----
>> drivers/staging/media/atomisp/i2c/atomisp-ov2722.c | 2 --
>> drivers/staging/media/atomisp/i2c/ov5693/atomisp-ov5693.c | 2 --
>> 4 files changed, 2 insertions(+), 12 deletions(-)
>>
>> diff --git a/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c b/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
>> index 9fa390fbc5f3..f10931a03285 100644
>> --- a/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
>> +++ b/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
>> @@ -840,9 +840,7 @@ static int gc2235_probe(struct i2c_client *client)
>> dev->ctrl_handler.lock = &dev->input_lock;
>> dev->sd.ctrl_handler = &dev->ctrl_handler;
>>
>> - ret = media_entity_pads_init(&dev->sd.entity, 1, &dev->pad);
>> - if (ret)
>> - gc2235_remove(client);
>
> Not related to your patch but why doesn't this error path return an
> error? Can that be right?
This is staging code and there are multiple camera sensor drivers under
drivers/staging/media/atomisp/i2c/
The gc2235 driver is one of the drivers which I have not yes tested
(I do have hw to test it, just no time), let alone worked on cleaning
it up...
Regards,
Hans
