On Thu, Oct 19, 2023 at 12:45:30PM +0200, Karolina Stolarek wrote: > On 19.10.2023 09:20, Soumya Negi wrote: > > vme.c uses printk() to log messages. To improve and standardize message > > formatting, use logging mechanisms pr_err()/pr_warn() and > > dev_err()/dev_warn() instead. Retain the printk log levels of the > > messages during replacement. > > > > Issue found by checkpatch.pl > > > > Signed-off-by: Soumya Negi <soumya.negi97@xxxxxxxxx> > > --- > > Changes in v2: > > * Change the pr_*() calls used to replace printk's in v1 to dev_*() > > wherever possible, as it adds more context to the message. > > (as per feedback from julia.lawall@xxxxxxxx & > > gregkh@xxxxxxxxxxxxxxxxxxx) > > You don't have to include the change log here, as it's already in the cover > letter. This space is usually used when a patch is not sent as a part of the > series. Either or both is fine, this is not a real issue at all, thanks greg k-h