On Thu, Oct 19, 2023 at 12:46:23PM +0300, Calvince Otieno wrote: > The functions vchiq_debugfs_init(), vchiq_debugfs_deinit(), > vchiq_debugfs_add_instance(), and vchiq_debugfs_remove_instance() > are declared and defined but contains no code or statements. > They do nothing. On the contrary, they do a lot! Try building with CONFIG_DEBUG_FS disabled and see what happens with your patch applied (hint, it breaks the build badly...) To be fair, the "empty" functions should be moved to the .h file, not the .c file, so if you want to do that, it would make more sense overall. thanks, greg k-h
