On Mon, Oct 16, 2023 at 09:39:33AM +0300, Calvince Otieno wrote: > Checkpatch suggests the use of strscpy() instead of strncpy(). > The advantages are that it always adds a NUL terminator and it prevents > a read overflow if the src string is not properly terminated. One > potential disadvantage is that it doesn't zero pad the string like > strncpy() does. > In this code, strscpy() and strncpy() are equivalent and it does not > affect runtime behavior. The string is zeroed on the line before > using memset(). The resulting string was always NUL terminated and > PRISM2_USB_FWFILE is string literal "prism2_ru.fw" so it's NUL > terminated. > However, even though using strscpy() does not fix any bugs, it's > still nicer and makes checkpatch happy. > > Signed-off-by: Calvince Otieno <calvncce@xxxxxxxxx> > --- > Previous Patch Versions: > - Earlier patch versions had issues with whitespace, preventing correct > application. This is a reroll of those previous versions. > > - Versions v2 through v6 focused on improving the clarity of the commit > message. There were no code changes in these patch versions. You forgot to put v6 in the subject... But it looks okay now. Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> regards, dan carpenter
