On Mon, Oct 16, 2023 at 07:40:57AM +0300, Dan Carpenter wrote: > On Fri, Oct 13, 2023 at 07:04:56PM +0300, Calvince Otieno wrote: > > On Fri, Oct 13, 2023 at 3:12 PM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > > > > > > On Fri, Oct 13, 2023 at 01:50:23PM +0300, Calvince Otieno wrote: > > > > prism2sta_inf_handover() function basically calls pr_debug() to print > > > > a literal string. This can be done by the parent function directly. > > > > > > > > Signed-off-by: Calvince Otieno <calvncce@xxxxxxxxx> > > > > --- > > > > Patch version v2: > > > > - Replace pr_debug() utility function with the module specific netdev_dbg() > > > > > > This isn't a v2 patch, right? This patch assumes that we applied the > > > v1 patch... > > > > > > This patch is not white space damaged though so that's good. > > > > > > regards, > > > dan carpenter > > > > > > > > > > Hello Dan, > > Does this response mean that the patch was accepted? > > Ugh... No, sorry. I suck at emails. White space damaged is not good. > I left out the word not... :/ > > You need to figure out what's going on there. Some of your patches are > not white space damaged so sometimes you're doing it right but here the > spaces were replaced with tabs so it doesn't apply. Wow... I absolutely suck at writing emails and *reading emails*. This wasn't the white space damaged patch. This was the okay one. However you sent a v2 patch in the wrong way. You just posted a fixup instead of resending the patch. You've sent v2 patches before but let me send you my blog link anyway... https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/ regards, dan carpenter
