On Wed, Jul 26, 2023 at 11:19:48PM -0700, Tree Davies wrote:
> Rename function ResetBaEntry to reset_ba_entry in order to Fix checkpatch
> warning: Avoid CamelCase
>
> Signed-off-by: Tree Davies <tdavies@xxxxxxxxxxxxxxx>
> ---
> v2: Sent with git send-email
> drivers/staging/rtl8192e/rtl819x_BAProc.c | 2 +-
> drivers/staging/rtl8192e/rtl819x_TSProc.c | 6 +++---
> drivers/staging/rtl8192e/rtllib.h | 2 +-
> 3 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
> index 9662d75257ce..cb6450206763 100644
> --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
> +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
> @@ -54,7 +54,7 @@ static u8 rx_ts_delete_ba(struct rtllib_device *ieee, struct rx_ts_record *pRxTs
> return bSendDELBA;
> }
>
> -void ResetBaEntry(struct ba_record *pBA)
> +void reset_ba_entry(struct ba_record *pBA)
> {
> pBA->b_valid = false;
> pBA->ba_param_set.short_data = 0;
> diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rtl8192e/rtl819x_TSProc.c
> index c61fdf73c572..21ffbb6b231f 100644
> --- a/drivers/staging/rtl8192e/rtl819x_TSProc.c
> +++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c
> @@ -117,8 +117,8 @@ static void ResetTxTsEntry(struct tx_ts_record *pTS)
> pTS->bAddBaReqDelayed = false;
> pTS->bUsingBa = false;
> pTS->bDisable_AddBa = false;
> - ResetBaEntry(&pTS->TxAdmittedBARecord);
> - ResetBaEntry(&pTS->TxPendingBARecord);
> + reset_ba_entry(&pTS->TxAdmittedBARecord);
> + reset_ba_entry(&pTS->TxPendingBARecord);
> }
>
> static void ResetRxTsEntry(struct rx_ts_record *pTS)
> @@ -126,7 +126,7 @@ static void ResetRxTsEntry(struct rx_ts_record *pTS)
> ResetTsCommonInfo(&pTS->ts_common_info);
> pTS->rx_indicate_seq = 0xffff;
> pTS->rx_timeout_indicate_seq = 0xffff;
> - ResetBaEntry(&pTS->rx_admitted_ba_record);
> + reset_ba_entry(&pTS->rx_admitted_ba_record);
> }
>
> void TSInitialize(struct rtllib_device *ieee)
> diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
> index e3ce4431d460..ccc9e7bbbcbb 100644
> --- a/drivers/staging/rtl8192e/rtllib.h
> +++ b/drivers/staging/rtl8192e/rtllib.h
> @@ -2016,7 +2016,7 @@ void TsInitDelBA(struct rtllib_device *ieee,
> void BaSetupTimeOut(struct timer_list *t);
> void TxBaInactTimeout(struct timer_list *t);
> void RxBaInactTimeout(struct timer_list *t);
> -void ResetBaEntry(struct ba_record *pBA);
> +void reset_ba_entry(struct ba_record *pBA);
Again, this is a global symbol name, please prefix it with rtllib_
thanks,
greg k-h
