Re: [PATCH] staging: ks7010: potential buffer overflow in ks_wlan_set_encode_ext()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Markus Elfring <Markus.Elfring@xxxxxx>
Subject: Re: [PATCH] staging: ks7010: potential buffer overflow in ks_wlan_set_encode_ext()
From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Date: Sun, 9 Jul 2023 21:42:47 +0200
Cc: Zhang Shurong <zhang_shurong@xxxxxxxxxxx>, linux-staging@xxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx, LKML <linux-kernel@xxxxxxxxxxxxxxx>, Dan Carpenter <error27@xxxxxxxxx>, Xu Panda <xu.panda@xxxxxxxxxx>
In-reply-to: <2a41ca22-a0eb-df38-be43-7175e1230bd0@web.de>
References: <tencent_5153B668C0283CAA15AA518325346E026A09@qq.com> <2a41ca22-a0eb-df38-be43-7175e1230bd0@web.de>

On Sun, Jul 09, 2023 at 09:21:45PM +0200, Markus Elfring wrote:
> > The "exc->key_len" is a u16 that comes from the user.  If it's over
> > IW_ENCODING_TOKEN_MAX (64) that could lead to memory corruption.
> 
> Please choose an imperative change suggestion.

Please stop reviewing staging patches, it is not helpful for anyone.

greg k-h

Follow-Ups:
- Re: staging: ks7010: potential buffer overflow in ks_wlan_set_encode_ext()
  - From: Markus Elfring

References:
- [PATCH] staging: ks7010: potential buffer overflow in ks_wlan_set_encode_ext()
  - From: Zhang Shurong
- Re: [PATCH] staging: ks7010: potential buffer overflow in ks_wlan_set_encode_ext()
  - From: Markus Elfring

Prev by Date: Re: [PATCH] staging: ks7010: potential buffer overflow in ks_wlan_set_encode_ext()
Next by Date: Re: staging: ks7010: potential buffer overflow in ks_wlan_set_encode_ext()
Previous by thread: Re: [PATCH] staging: ks7010: potential buffer overflow in ks_wlan_set_encode_ext()
Next by thread: Re: staging: ks7010: potential buffer overflow in ks_wlan_set_encode_ext()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Driver Development] [Linux Driver Backports] [DMA Engine] [Linux GPIO] [Linux SPI] [Video for Linux] [Linux USB Devel] [Linux Coverity] [Linux Audio Users] [Linux Kernel] [Linux SCSI] [Yosemite Backpacking]