Re: [PATCH] staging: ks7010: potential buffer overflow in ks_wlan_set_encode_ext()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Zhang Shurong <zhang_shurong@xxxxxxxxxxx>, linux-staging@xxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH] staging: ks7010: potential buffer overflow in ks_wlan_set_encode_ext()
From: Markus Elfring <Markus.Elfring@xxxxxx>
Date: Sun, 9 Jul 2023 21:21:45 +0200
Cc: LKML <linux-kernel@xxxxxxxxxxxxxxx>, Dan Carpenter <error27@xxxxxxxxx>, Xu Panda <xu.panda@xxxxxxxxxx>
In-reply-to: <tencent_5153B668C0283CAA15AA518325346E026A09@qq.com>
References: <tencent_5153B668C0283CAA15AA518325346E026A09@qq.com>
Ui-outboundreport: notjunk:1;M01:P0:VCpkI1KCuG8=;GuAeD+bxldkcQAvx5wEdFpklokp rlovcCf+uXGeO+zUnAVGlcR0bI0Oi7HfPePKMQuyLk5KnAXGyC9qAANZdVcllvM4szAVqxz5O 2H8m0S9YZHqfHozTuL5/UEw5W0lLWUvpLyZh94DSLSXfrhzoRMcbzaEjuV2Fkjr1xhqJ/OZpQ z+HZjNpfdcWCpd4lLrpsGgA1cY5tItTz2jBBlYHH3gC3b9zBsvm2kwcSN8sc6AWDph/2BGucd Y7iR3OQGL4b/OPrQEJIJr3AYipdROpDKucZazka1BnCtMJifRnruzDAFGAlWMnRFTNAJamRKm yU17scND1t5Ka4uNHvO/43VXysGOdIHqzeoinyaLD5rmnpXvkJfr/ZvizfLqsCwcSR57cCN5Y pvLI1HsvjJrQGspyKJy4jcLPigZh+noSfMRqPH/i7LxQZ4x0BXiHPUM6ulC/yDt5RuAjET7xs MYhXCkxFqrAJ36QEUxyrHtvRvSIhKeoFg1siMa2p6Wp1aUTzDadWsJYRRTUf8z0/sdJMPeVKd Mh54ZDM+8FJgzUoVAp/qWTCER7jNfl0e8PXtjEoeIo0kMZ7ZKY87X3ojgzJ2wHj44/FvyBXEi JE7Yyfb8YyUpEd21jCjxz5On/Y+UkPMGIZ4FrsK+YnRN7bRgldXcItL2TEHpTz2SLG1Fzr80l 2f2B8x0d9HiJf6Hp39AYJYc2Dd64+AFZ8sLl+8BmXXIEJkBcNj2qIyA2OG4E3qhDVykLD7Le1 oEaNXdE3OknUIVFP00MVPB0cj8kT2J80WWtVwYEaw7RI7V2Weibx2QO9MMYHnp8Zb1yAt0Kvz AQf0e+/RVdpO8vRML1zrgfnKirszkfW/UoG2lrI/CXe63u06jQZcmnfhgW4kzWXqblpnZDpjl sJwFR2k6jPWgkNbpKf5MRMBUC8QpIniM5A48l4tNPS+Yj6zc3VbPjcqJW9JVlxKOScaTD31tt tz+IUg==
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0

> The "exc->key_len" is a u16 that comes from the user.  If it's over
> IW_ENCODING_TOKEN_MAX (64) that could lead to memory corruption.

Please choose an imperative change suggestion.

See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.4#n94

Regards,
Markus

Follow-Ups:
- Re: [PATCH] staging: ks7010: potential buffer overflow in ks_wlan_set_encode_ext()
  - From: Greg Kroah-Hartman

References:
- [PATCH] staging: ks7010: potential buffer overflow in ks_wlan_set_encode_ext()
  - From: Zhang Shurong

Prev by Date: [PATCH] staging: ks7010: potential buffer overflow in ks_wlan_set_encode_ext()
Next by Date: Re: [PATCH] staging: ks7010: potential buffer overflow in ks_wlan_set_encode_ext()
Previous by thread: [PATCH] staging: ks7010: potential buffer overflow in ks_wlan_set_encode_ext()
Next by thread: Re: [PATCH] staging: ks7010: potential buffer overflow in ks_wlan_set_encode_ext()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Driver Development] [Linux Driver Backports] [DMA Engine] [Linux GPIO] [Linux SPI] [Video for Linux] [Linux USB Devel] [Linux Coverity] [Linux Audio Users] [Linux Kernel] [Linux SCSI] [Yosemite Backpacking]