Am Do., 29. Juni 2023 um 09:40 Uhr schrieb Dan Carpenter <dan.carpenter@xxxxxxxxxx>: > > On Wed, Jun 28, 2023 at 06:38:03PM +0200, Franziska Näpelt wrote: > > > > Do you want me to submit v4 to fix the email address as well as the subject of > > the cover letter or are you ok with me promising to make it properly the next > > time? ;) > > Philipp is not the person to ask, it's Greg. > > Yes, you are going to need to resend because of the email address thing. > > Probably the cover letter is not a reason to resend, but since you are > resending then please fix that as well. > > The reason why we insist that you resend is a couple things: > 1) This is a checkpatch change to staging so we assume that you're just > doing it to learn how patches are supposed to be sent. So this is an > educational opportunity. ;) > 2) Greg maintains staging, usb, serial and -stable. He's super busy. > It doesn't scale to hand edit patches. Some maintainers are less > busy so they can fix trivial stuff like this but in staging you will > need to resend. Also if it were a security fix maybe I would step > in and help you fix your patch but since it's just a checkpatch thing > no one is going to edit your patch. > > Right now the merge window is open so Greg isn't going to see your patch > for a few weeks. When he does he will press the button on his keyboard > which sends an automatic reply about the email address thing and deletes > the thread from his inbox. > > regards, > dan carpenter Thanks for your help and the comprehensive explanation Dan and Philipp :) Just send v4: https://lore.kernel.org/linux-staging/20230701102223.5308-1-franziska.naepelt@xxxxxxxxxxxxxx/T/#t
