+ Arnd On Wed, Apr 19, 2023 at 1:51 AM Simon Horman <horms@xxxxxxxxxx> wrote: > > On Wed, Apr 19, 2023 at 08:37:58AM +0200, Stefan Wahren wrote: > > Hi Simon, > > > > Am 18.04.23 um 13:23 schrieb Simon Horman: > > > vchiq_platform_init() is only used in this file so it can be static. > > > > > > clang-16 with W=1 reports: > > > > > > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:465:5: error: no previous prototype for function 'vchiq_platform_init' [-Werror,-Wmissing-prototypes] > > > int vchiq_platform_init(struct platform_device *pdev, struct vchiq_state *state) > > > ^ > > > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:465:1: note: declare 'static' if the function is not intended to be used outside of this translation unit > > > > > > Signed-off-by: Simon Horman <horms@xxxxxxxxxx> > > > > this is not the first attempt to fix this [1]. But maybe this has been fixed > > in the meantime. > > > > [1] - https://lore.kernel.org/linux-staging/20221022043548.1671644-1-scottjcrouch@xxxxxxxxx/#t > > Thanks, > > I see in that thread that Greg notes that "this breaks the build in a very > horrible and strange way" [2]. So Arnd had a Kconfig suggestion later in that thread: https://lore.kernel.org/linux-staging/d64dc0b4-ba82-49f4-9a43-c50b735ad91d@xxxxxxxxxxxxxxxx/ Marking something as `depends on OF_DYNAMIC`. (Not sure whether Arnd meant that for BCM2835_VCHIQ or BCM_VIDEOCORE). Perhaps try that? > > I'm a bit surprised as I didn't observe such a thing. > But I also don't dispute it - clearly my testing was inadequate. > > I'll try and dig a bit deeper into this one. > Perhaps starting with the report from the kernel test robot [3] > > [2] https://lore.kernel.org/linux-staging/Y1Okpjbi2kKU2GFz@xxxxxxxxx/ > [3] https://lore.kernel.org/linux-staging/202210230127.p1Dp295m-lkp@xxxxxxxxx/ -- Thanks, ~Nick Desaulniers
