Fair enough. Also I wouldn't have said anything if the patch had been checkpatch clean. I was testing to see if the extra --- lines mattered and that's when git complained about white space problems and it's like you say, the extra --- lines don't cause an issue. regards, dan carpenter