On Sat, Mar 18, 2023 at 09:35:49PM +0800, Kloudifold wrote: > sm750 driver has sm750_hw_cursor_* functions, which are named in > camelcase. Rename them to snake case to follow the function naming > convention. > > Signed-off-by: Kloudifold <cloudifold.3125@xxxxxxxxx> > Delete this blank line before the ---. > --- > Changes in v3: > - Add this changelog (Philipp) > - Move lkp tags and link to the correct location in commit log (Alison) > - Update the commit msg (Philip) > - Update the commit log (Bagas, Julia) > > Changes in v2: > - Use new function names in call sites (LKP) > > This v2 patch was prompted by an error reported by the Linux test > robot, which detected the compile error. > Reported-by: kernel test robot <lkp@xxxxxxxxx> > Link: https://lore.kernel.org/oe-kbuild-all/202303110849.X24WnHnM-lkp@xxxxxxxxx/ > --- > --- Delete these two --- lines. > drivers/staging/sm750fb/sm750.c | 22 +++++++++++----------- > drivers/staging/sm750fb/sm750_cursor.c | 14 +++++++------- > drivers/staging/sm750fb/sm750_cursor.h | 12 ++++++------ > 3 files changed, 24 insertions(+), 24 deletions(-) I would have ignored the issues above but when I went to apply the patch git complained about whitespace problems. So then I ran checkpatch on the patch and it complains a lot. ERROR: code indent should use tabs where possible #61: FILE: drivers/staging/sm750fb/sm750.c:130: +^I^I^I^I ^Ifbcursor->image.dx - info->var.xoffset,$ WARNING: please, no space before tabs #61: FILE: drivers/staging/sm750fb/sm750.c:130: +^I^I^I^I ^Ifbcursor->image.dx - info->var.xoffset,$ CHECK: Alignment should match open parenthesis #61: FILE: drivers/staging/sm750fb/sm750.c:130: + sm750_hw_cursor_set_pos(cursor, + fbcursor->image.dx - info->var.xoffset, ERROR: code indent should use tabs where possible #62: FILE: drivers/staging/sm750fb/sm750.c:131: +^I^I^I^I ^Ifbcursor->image.dy - info->var.yoffset);$ WARNING: please, no space before tabs #62: FILE: drivers/staging/sm750fb/sm750.c:131: +^I^I^I^I ^Ifbcursor->image.dy - info->var.yoffset);$ total: 2 errors, 2 warnings, 1 checks, 99 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. NOTE: Whitespace errors detected. You may wish to use scripts/cleanpatch or scripts/cleanfile "[PATCH v3] staging: sm750: Rename sm750_hw_cursor_* functions to" has style problems, please review. regards, dan carpenter
