On Fri, Feb 10, 2023 at 01:05:52PM +0200, Laurent Pinchart wrote: > On Fri, Feb 10, 2023 at 12:53:43PM +0200, Andy Shevchenko wrote: > > On Fri, Feb 10, 2023 at 12:47:55PM +0200, Sakari Ailus wrote: > > > On Fri, Feb 10, 2023 at 12:29:19PM +0200, Laurent Pinchart wrote: > > > > On Fri, Feb 10, 2023 at 12:21:15PM +0200, Sakari Ailus wrote: > > > > > On Thu, Feb 09, 2023 at 06:11:12PM +0200, Laurent Pinchart wrote: ... > > > > > I took a look at this some time ago, too, and current regmap API is a poor > > > > > fit for CCI devices. CCI works on top of e.g. both I²C and I3C so something > > > > > on top of regmap is a better approach indeed. > > > > > > > > I'm confused, is regmap a poor fit, or a better approach ? > > > > > > I'm proposing having something on top of regmap, but not changing regmap > > > itself. > > > > I don't understand why we can't change regmap? regmap has a facility called > > regmap bus which we can provide specifically for these types of devices. What's > > wrong to see it done? > > How would that work ? If I'm not mistaken, you may introduce something like regmal CCI and then regmap_init_cci(); regmap_read()/regmap_write() regmap_update_bits() regmap_bulk_*() at your service without changing a bit in the drivers (they will use plain regmap APIs instead of custom ones). -- With Best Regards, Andy Shevchenko
