Re: [PATCH] staging: pi433: modify bit_rate from u16 to u32

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 31, 2023 at 02:14:12PM +0300, Dan Carpenter wrote:
> On Tue, Jan 31, 2023 at 11:52:41AM +0100, Guru Mehar Rachaputi wrote:
> 
> > I would like to know, if it is mentioned in the TODO, why is it
> > so?
> > 
> 
> If it were as simple as just changing the type, they would have done
> that instead of adding it to the TODO.  :P
> 
> But in fairness the TODO entry is sort of vague and useless.  It should
> say that this configuration stuff needs to be moved to sysfs instead of
> being done through an IOCTL.  The we would need to port the userspace
> tools to use sysfs instead of the IOCTL.  Then we would delete the
> IOCTL.
> 
> https://lore.kernel.org/all/20220118135902.GH1951@kadam/
> 
> If you want to send a patch to update the TODO then you can do that.
> 
> regards,
> dan carpenter
> 
Thanks for your mail.

I have now updated TODO file and submitted as a patch.

-- 
Thanks & Regards,
Guru




[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux