Re: [PATCH 43/57] media: atomisp: ov2680: Drop MAX_FMTS define

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 23, 2023 at 01:51:51PM +0100, Hans de Goede wrote:
> The ov2680 only supports a single format, there is no need to
> use a define for this.

Reviewed-by: Andy Shevchenko <andy@xxxxxxxxxx>

(One nit-pick below)

> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> ---
>  drivers/staging/media/atomisp/i2c/atomisp-ov2680.c | 2 +-
>  drivers/staging/media/atomisp/i2c/ov2680.h         | 2 --
>  2 files changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c
> index 81fd36b09090..994b6fe40069 100644
> --- a/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c
> +++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c
> @@ -687,7 +687,7 @@ static int ov2680_enum_mbus_code(struct v4l2_subdev *sd,
>  				 struct v4l2_subdev_state *sd_state,
>  				 struct v4l2_subdev_mbus_code_enum *code)
>  {
> -	if (code->index >= MAX_FMTS)
> +	if (code->index)

Perhaps a comment above?

	/* We support only a single format */

>  		return -EINVAL;
>  
>  	code->code = MEDIA_BUS_FMT_SBGGR10_1X10;
> diff --git a/drivers/staging/media/atomisp/i2c/ov2680.h b/drivers/staging/media/atomisp/i2c/ov2680.h
> index 189d1b2b7584..5aa46f669715 100644
> --- a/drivers/staging/media/atomisp/i2c/ov2680.h
> +++ b/drivers/staging/media/atomisp/i2c/ov2680.h
> @@ -46,8 +46,6 @@
>  
>  #define OV2680_FOCAL_LENGTH_NUM	334	/*3.34mm*/
>  
> -#define MAX_FMTS		1
> -
>  #define OV2680_INTEGRATION_TIME_MARGIN	8
>  #define OV2680_ID	0x2680
>  
> -- 
> 2.39.0
> 

-- 
With Best Regards,
Andy Shevchenko






[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux