Re: [RFC PATCH 0/4] Drop custom logging

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Kieran,

Am 22.01.23 um 17:26 schrieb Kieran Bingham:
Hi Stefan,

Quoting Stefan Wahren (2023-01-22 14:21:05)
Hi Umang,

Am 18.01.23 um 12:58 schrieb Umang Jain:
Drop custom logging from the vchiq interface.
Mostly of them are replaced with dev_dbg and friends
and/or pr_info and friends.

The debugfs log levels (in 4/4) are mapped to kernel
logs levels (coming from include/linux/kern_levels.h)
Would like some thoughts on it as I am not sure (hence
marking this is RFC)

  From drivers/staging/vc04_services/interface/TODO:

"""
* Cleanup logging mechanism

The driver should probably be using the standard kernel logging mechanisms
such as dev_info, dev_dbg, and friends.
"""
at first i want to thank you for the work on vchiq so far.

There is something which is not directly related to this series, but it
is also about debugging. The driver has a buffer which is accessed by
it's own DEBUG_* macros. The content of this debug buffer can be dumped
via the /dev/vchiq which is also used by ioctl. I would appreciate to
move this dump feature into a new debugfs entry.
Do you have a full list of the tasks you'd like to see completed ?
(including/or above drivers/staging/vc04_services/interface/TODO)

i consider every point except of point 1 (importing new drivers) as necessary to leave staging.

Additionally there is the additional point (i can add them to the TODO) above. Unfortunately i don't have a complete insight, how vchiq should be to be acceptable. Sorry, if i can't help you further with possible resource planning.

Are some points on the TODO list unclear?

Thanks


It would help to have a clear picture of tasks needed to get this driver
destaged, so that we can support the ISP upstream.

Regards
--
Kieran




[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux