Hi Stefan, Quoting Stefan Wahren (2023-01-22 14:21:05) > Hi Umang, > > Am 18.01.23 um 12:58 schrieb Umang Jain: > > Drop custom logging from the vchiq interface. > > Mostly of them are replaced with dev_dbg and friends > > and/or pr_info and friends. > > > > The debugfs log levels (in 4/4) are mapped to kernel > > logs levels (coming from include/linux/kern_levels.h) > > Would like some thoughts on it as I am not sure (hence > > marking this is RFC) > > > > From drivers/staging/vc04_services/interface/TODO: > > > > """ > > * Cleanup logging mechanism > > > > The driver should probably be using the standard kernel logging mechanisms > > such as dev_info, dev_dbg, and friends. > > """ > > at first i want to thank you for the work on vchiq so far. > > There is something which is not directly related to this series, but it > is also about debugging. The driver has a buffer which is accessed by > it's own DEBUG_* macros. The content of this debug buffer can be dumped > via the /dev/vchiq which is also used by ioctl. I would appreciate to > move this dump feature into a new debugfs entry. Do you have a full list of the tasks you'd like to see completed ? (including/or above drivers/staging/vc04_services/interface/TODO) It would help to have a clear picture of tasks needed to get this driver destaged, so that we can support the ISP upstream. Regards -- Kieran
