Hi Pavel, Thus wrote Pavel Skripkin (paskripkin@xxxxxxxxx): > Martin Kaiser <martin@xxxxxxxxx> says: > > rtl8188eu_inirp_init's return value is not checked by its caller. Make > > rtl8188eu_inirp_init a void function. > Hm, shouldn't we actually check return value on caller side? > This thing is called from netdev_open and issues urbs to read data from the > device. So let's imagine that we fail on 1st iteration (for some reason): > netdev_open() says all is OK, but driver does not communicate with the > device. your're right. It makes sense to relay the return value to _netdev_open. We'd have to update/remove the intf_start pointer and usb_intf_start. I'll resend the series without this patch and submit new patches for relaying the error code. Thanks & best regards, Martin
