Hi Martin,
Martin Kaiser <martin@xxxxxxxxx> says:
rtl8188eu_inirp_init's return value is not checked by its caller. Make
rtl8188eu_inirp_init a void function.
Signed-off-by: Martin Kaiser <martin@xxxxxxxxx>
---
drivers/staging/r8188eu/hal/usb_halinit.c | 14 +++-----------
drivers/staging/r8188eu/include/hal_intf.h | 2 +-
2 files changed, 4 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8188eu/hal/usb_halinit.c
index d28b4dc2a767..afa24a59fbb3 100644
--- a/drivers/staging/r8188eu/hal/usb_halinit.c
+++ b/drivers/staging/r8188eu/hal/usb_halinit.c
@@ -851,29 +851,21 @@ u32 rtl8188eu_hal_deinit(struct adapter *Adapter)
return _SUCCESS;
}
-unsigned int rtl8188eu_inirp_init(struct adapter *Adapter)
+void rtl8188eu_inirp_init(struct adapter *Adapter)
Hm, shouldn't we actually check return value on caller side?
This thing is called from netdev_open and issues urbs to read data from
the device. So let's imagine that we fail on 1st iteration (for some
reason): netdev_open() says all is OK, but driver does not communicate
with the device.
Maybe these urbs are not that important, tho..
With regards,
Pavel Skripkin
