On Wed, Oct 19, 2022 at 10:28:42PM -0700, Emily Peri wrote: > On Thu, Oct 20, 2022 at 06:57:03AM +0200, Greg KH wrote: > > On Wed, Oct 19, 2022 at 07:10:51PM -0700, Emily Peri wrote: > > > Fix the following checkpatch warnings in rtw_ioctl_set: > > > 1) Add missing blankline after declaration > > > 2) Replace spaces used for indent with tab > > > 3) Remove space before tab > > > > When you have to list the different things you do, you should really > > break that up into individual patches. This should be 3. > > > > thanks, > > > > greg k-h > > Thanks greg for the feedback! I got the idea to put them all in the same > patch from the PatchPhilosophy guide, which suggested combining a bunch > of white space corrections into one commit. But, it sounds like I > misinterpreted what the guide was saying. Maybe if there are identical > warnings, such as "trailing white space" in the driver code, could those > corrections go together in a single patch? > Yes, you are correct, you could do a "fix all trailing whitespace in this file" in one patch. thanks, greg k-h
