Re: [PATCH] staging: rtl8192e: fix CamelCase struct member

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Sep 18, 2022 at 01:49:26PM +0200, Valentin Vidic wrote:
> Fix checkpatch warnings for struct member pFirmware.
> 
> Signed-off-by: Valentin Vidic <vvidic@xxxxxxxxxxxxxxxxxxxxxx>
> ---
>  drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c      | 8 ++++----
>  drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 4 ++--
>  drivers/staging/rtl8192e/rtl8192e/rtl_core.c        | 8 ++++----
>  drivers/staging/rtl8192e/rtl8192e/rtl_core.h        | 2 +-
>  4 files changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> index 4b9249195b5a..6308a25e064c 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> @@ -707,19 +707,19 @@ bool rtl92e_start_adapter(struct net_device *dev)
>  		rtl92e_writeb(dev, ANAPAR, 0x37);
>  		mdelay(500);
>  	}
> -	priv->pFirmware->status = FW_STATUS_0_INIT;
> +	priv->pfirmware->status = FW_STATUS_0_INIT;

What does "pfirmware" mean here?

If you fix up camelcase warnings, please do so in a way that is the
proper Linux kernel style, not just making everything lowercase.

Look up Hungarian notation and why the original was named this way and
why this isn't needed in Linux at all (i.e. we have modern compilers.)

thanks,

greg k-h




[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux