Re: [PATCH v2] staging: rtl8723bs: remove braces in single statement blocks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thanks for your kind review!

Regards,

Kang


2022년 9월 14일 (수) 오전 1:25, Kang Minchul <tegongkang@xxxxxxxxx>님이 작성:
>
> This commit cleans up checkpatch warning as follows:
> WARNING: braces {} are not necessary for single statement blocks
>
> Signed-off-by: Kang Minchul <tegongkang@xxxxxxxxx>
> ---
> Reverted erased code which invokes error.
>
>  drivers/staging/rtl8723bs/core/rtw_recv.c | 16 +++++-----------
>  1 file changed, 5 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
> index d8d394b67eeb..f360c7c631cb 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_recv.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
> @@ -1374,9 +1374,8 @@ static signed int validate_80211w_mgmt(struct adapter *adapter, union recv_frame
>                         /* actual management data frame body */
>                         data_len = pattrib->pkt_len - pattrib->hdrlen - pattrib->iv_len - pattrib->icv_len;
>                         mgmt_DATA = rtw_zmalloc(data_len);
> -                       if (!mgmt_DATA) {
> +                       if (!mgmt_DATA)
>                                 goto validate_80211w_fail;
> -                       }
>                         precv_frame = decryptor(adapter, precv_frame);
>                         /* save actual management data frame body */
>                         memcpy(mgmt_DATA, ptr+pattrib->hdrlen+pattrib->iv_len, data_len);
> @@ -1385,9 +1384,8 @@ static signed int validate_80211w_mgmt(struct adapter *adapter, union recv_frame
>                         /* remove the iv and icv length */
>                         pattrib->pkt_len = pattrib->pkt_len - pattrib->iv_len - pattrib->icv_len;
>                         kfree(mgmt_DATA);
> -                       if (!precv_frame) {
> +                       if (!precv_frame)
>                                 goto validate_80211w_fail;
> -                       }
>                 } else if (IS_MCAST(GetAddr1Ptr(ptr)) &&
>                         (subtype == WIFI_DEAUTH || subtype == WIFI_DISASSOC)) {
>                         signed int BIP_ret = _SUCCESS;
> @@ -1651,14 +1649,12 @@ static int check_indicate_seq(struct recv_reorder_ctrl *preorder_ctrl, u16 seq_n
>         u16 wend = (preorder_ctrl->indicate_seq + wsize - 1) & 0xFFF;/*  4096; */
>
>         /*  Rx Reorder initialize condition. */
> -       if (preorder_ctrl->indicate_seq == 0xFFFF) {
> +       if (preorder_ctrl->indicate_seq == 0xFFFF)
>                 preorder_ctrl->indicate_seq = seq_num;
> -       }
>
>         /*  Drop out the packet which SeqNum is smaller than WinStart */
> -       if (SN_LESS(seq_num, preorder_ctrl->indicate_seq)) {
> +       if (SN_LESS(seq_num, preorder_ctrl->indicate_seq))
>                 return false;
> -       }
>
>         /*  */
>         /*  Sliding window manipulation. Conditions includes: */
> @@ -2084,10 +2080,8 @@ s32 rtw_recv_entry(union recv_frame *precvframe)
>         precvpriv = &padapter->recvpriv;
>
>         ret = recv_func(padapter, precvframe);
> -       if (ret == _FAIL) {
> +       if (ret == _FAIL)
>                 goto _recv_entry_drop;
> -       }
> -
>
>         precvpriv->rx_pkts++;
>
> --
> 2.34.1
>





[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux