On Mon, Sep 05, 2022 at 09:23:15AM +0800, Guozihua (Scott) wrote: > Hi Greg, > > Sorry for the confusion. > > On 2022/9/2 16:25, Greg KH wrote: > > On Fri, Sep 02, 2022 at 04:16:53PM +0800, GUO Zihua wrote: > > > Since Linux now supports CFI, it will be a good idea to fix mismatched > > > return type for implementation of hooks. Otherwise this might get > > > cought out by CFI and cause a panic. > > > > > > Use enums from netdev_tx_t as return value instead, then change return > > > type to netdev_tx_t. > > > > > > Signed-off-by: GUO Zihua <guozihua@xxxxxxxxxx> > > > --- > > > drivers/staging/r8188eu/include/xmit_osdep.h | 2 +- > > > drivers/staging/r8188eu/os_dep/xmit_linux.c | 4 ++-- > > > 2 files changed, 3 insertions(+), 3 deletions(-) > > > > Why is this and the other commits, marked as RESEND? > > The first version of the patch has a truncated subject, thus the resend. It > might be better to send a v2 patches instead.. Yes please do that. > > And any reason you didn't cc: the staging maintainer on this commit? > > It's my first time sending patches to the staging maillist. When I run > get_maintainer.pl on the patch I don't see a "maintainer", but only > "supporters" and "reviewers". Is that for staging there are a group of > maintainers for all modules? See the MAINTAINERS file for what "supported" and "maintained" and the rest mean and just include them all when you submit a patch. thanks, greg k-h
