Re: [RESEND PATCH] staging: r8188eu: Fix return type for implementation of ndo_start_xmit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Greg,

Sorry for the confusion.

On 2022/9/2 16:25, Greg KH wrote:
On Fri, Sep 02, 2022 at 04:16:53PM +0800, GUO Zihua wrote:
Since Linux now supports CFI, it will be a good idea to fix mismatched
return type for implementation of hooks. Otherwise this might get
cought out by CFI and cause a panic.

Use enums from netdev_tx_t as return value instead, then change return
type to netdev_tx_t.

Signed-off-by: GUO Zihua <guozihua@xxxxxxxxxx>
---
  drivers/staging/r8188eu/include/xmit_osdep.h | 2 +-
  drivers/staging/r8188eu/os_dep/xmit_linux.c  | 4 ++--
  2 files changed, 3 insertions(+), 3 deletions(-)

Why is this and the other commits, marked as RESEND?

The first version of the patch has a truncated subject, thus the resend. It might be better to send a v2 patches instead..

And any reason you didn't cc: the staging maintainer on this commit?

It's my first time sending patches to the staging maillist. When I run get_maintainer.pl on the patch I don't see a "maintainer", but only "supporters" and "reviewers". Is that for staging there are a group of maintainers for all modules?

confused,

greg k-h
.
--
Best
GUO Zihua




[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux