On Fri, Sep 2, 2022 at 12:10 PM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
> On Fri, Sep 2, 2022 at 12:04 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
> > On 9/1/22 21:56, Andy Shevchenko wrote:
> > > On Thu, Sep 01, 2022 at 11:46:22AM +0200, Hans de Goede wrote:
>
> ...
>
> > >> for (; i > 0; i--)
> > >> atomisp_subdev_unregister_entities(
> > >> &isp->asd[i - 1]);
> > >
> > > This...
> >
> > I presume you mean the few lines above that actually:
>
> No, I cited a not modified code in the upper part. That said, it's a
> remark for further improvements, but a helper can be introduced in
> this patch due to the below part.
>
> > >> + for (i = 0; i < isp->num_of_streams; i++) {
> > >> + err = atomisp_subdev_register_video_nodes(&isp->asd[i], &isp->v4l2_dev);
> > >> + if (err)
> > >> + return err;
> > >> + }
> > >
> > > ...and this looks like a dup.
Pushed "enter" too early to send.
But with your explanation I see the difference now.
--
With Best Regards,
Andy Shevchenko
