Re: [RESEND PATCH] staging: r8188eu: Fix return type for implementation of ndo_start_xmit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is not a RESEND.  A RESEND means your patch was perfect and the
problem was on our end.  Of course, we're also human so sometimes we
make mistakes but a RESEND requires an investigation why we are
ignoring *perfect* patches.

This is a V2 patch.  Here is my blog entry on how to send a v2 patch:
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
You need to send a v3 patch now.

On Fri, Sep 02, 2022 at 04:16:53PM +0800, GUO Zihua wrote:
> Since Linux now supports CFI, it will be a good idea to fix mismatched
> return type for implementation of hooks. Otherwise this might get
> cought out by CFI and cause a panic.
> 
> Use enums from netdev_tx_t as return value instead, then change return
> type to netdev_tx_t.

What CFI is C-something Fault Injection?  How does this cause a panic?
Do you have a stack trace?  This commit message is not clear at all.

regards,
dan carpenter





[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux