Re: [PATCH] Split multiple assignments to individual lines.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 22, 2022 at 08:05:57PM +0200, Philipp Hortmann wrote:
> I personally prefer more this:
> 
> > +	sm750_dev->fbinfo[1] = NULL;
> > +	sm750_dev->fbinfo[0] = NULL;
> 
> That gives a better overview.
> 

Same for everywhere.  Literals are clear than variables.

 Bad:	foo = bar;
Good:	foo = -1;

Avoid pointless indirection.

regards,
dan carpenter





[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux