On Mon, Aug 22, 2022 at 08:05:57PM +0200, Philipp Hortmann wrote: > I personally prefer more this: > > > + sm750_dev->fbinfo[1] = NULL; > > + sm750_dev->fbinfo[0] = NULL; > > That gives a better overview. > Same for everywhere. Literals are clear than variables. Bad: foo = bar; Good: foo = -1; Avoid pointless indirection. regards, dan carpenter