Re: [PATCH] Split multiple assignments to individual lines.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 8/22/22 17:41, Christopher Carbone wrote:
Adhere to Linux kernel coding style.

Reported by checkpatch:

CHECK: multiple assignments should be avoided

Signed-off-by: Christopher Carbone <chris.m.carbone@xxxxxxxxx>
---
  drivers/staging/sm750fb/sm750.c | 12 ++++++++----
  1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index dbd1159a2ef0..a0f8ae359248 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -386,7 +386,8 @@ static int lynxfb_ops_set_par(struct fb_info *info)
ret = lynxfb_set_color_offsets(info); - var->height = var->width = -1;
+	var->width = -1;
+	var->height = var->width;
  	var->accel_flags = 0;/*FB_ACCELF_TEXT;*/
if (ret) {
@@ -498,7 +499,8 @@ static int lynxfb_ops_check_var(struct fb_var_screeninfo *var,
  		return ret;
  	}
- var->height = var->width = -1;
+	var->width = -1;
+	var->height = var->width;
  	var->accel_flags = 0;/* FB_ACCELF_TEXT; */
/* check if current fb's video memory big enough to hold the onscreen*/
@@ -723,7 +725,8 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index)
  		0x800f0 + (int)crtc->channel * 0x140;
pr_info("crtc->cursor.mmio = %p\n", crtc->cursor.mmio);
-	crtc->cursor.max_h = crtc->cursor.max_w = 64;
+	crtc->cursor.max_w = 64;
+	crtc->cursor.max_h = crtc->cursor.max_w;
  	crtc->cursor.size = crtc->cursor.max_h * crtc->cursor.max_w * 2 / 8;
  	crtc->cursor.vstart = sm750_dev->pvMem + crtc->cursor.offset;
@@ -1027,7 +1030,8 @@ static int lynxfb_pci_probe(struct pci_dev *pdev,
  	if (!sm750_dev)
  		return err;
- sm750_dev->fbinfo[0] = sm750_dev->fbinfo[1] = NULL;
+	sm750_dev->fbinfo[1] = NULL;
+	sm750_dev->fbinfo[0] = sm750_dev->fbinfo[1];
  	sm750_dev->devid = pdev->device;
  	sm750_dev->revid = pdev->revision;
  	sm750_dev->pdev = pdev;


Hi,

the subsystem and the device is missing in the Subject.

I propose you look into https://kernelnewbies.org/FirstKernelPatch to read about the Subject.

I personally prefer more this:

> +	sm750_dev->fbinfo[1] = NULL;
> +	sm750_dev->fbinfo[0] = NULL;

That gives a better overview.

Thanks for your support.

Bye Philipp





[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux