Hi, On 8/20/22 16:35, Nam Cao wrote: > Hi > > On Sat, Aug 20, 2022 at 2:17 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: >> >> Hi, >> >> Patch 1/4 seems to be missing? > > Patch 1/4 is there: > https://lore.kernel.org/linux-staging/46d73e331bae2192a328f6691763f39ea6c18b08.1660977536.git.namcaov@xxxxxxxxx/ > >> >> Also please squash patches 3 and 4: >> >> staging: rtl8723bs: remove odm_NoiseMonitor.o from Makefile >> staging: rtl8723bs: remove odm_NoiseMonitor.h and odm_NoiseMonitor.c >> >> together. Ion other words remove both the files and the Makefile >> target in a single patch please. > > Sorry but I am not sure what I am supposed to do with kernel test bot. > I agree that it makes sense to squash these 2 commits together. However, > I separated them because I want to have 1 patch addressing the problem reported > by the bot, so that I can put the "Reported-by" line to this patch. > > If I squash them, should I still put in the "Reported-by" line, despite the > commit not exactly fixing the reported error. Or should I just leave it out? You should just leave it out, that is the standard thing to do for bot reported problems which are fixed before the patches are merged. Regards, Hans
