Hi, Patch 1/4 seems to be missing? Also please squash patches 3 and 4: staging: rtl8723bs: remove odm_NoiseMonitor.o from Makefile staging: rtl8723bs: remove odm_NoiseMonitor.h and odm_NoiseMonitor.c together. Ion other words remove both the files and the Makefile target in a single patch please. Regards, Hans On 8/20/22 08:42, Nam Cao wrote: > Delete odm_NoiseMonitor.c and odm_NoiseMonitor.h because they are > useless. The first 2 commits are preparation, and the final commit is > actual removal. > > v2: Add new patch to remove the file from Makefile, otherwise there is > build error as reported by kernel test bot. > > Nam Cao (4): > staging: rtl8723bs: remove unused function ODM_InbandNoise_Monitor > staging: rtl8723bs: remove member noise_level from struct dm_odm_t > staging: rtl8723bs: remove odm_NoiseMonitor.o from Makefile > staging: rtl8723bs: remove odm_NoiseMonitor.h and odm_NoiseMonitor.c > > drivers/staging/rtl8723bs/Makefile | 1 - > drivers/staging/rtl8723bs/hal/odm.h | 2 - > .../staging/rtl8723bs/hal/odm_NoiseMonitor.c | 130 ------------------ > .../staging/rtl8723bs/hal/odm_NoiseMonitor.h | 39 ------ > drivers/staging/rtl8723bs/hal/odm_precomp.h | 1 - > 5 files changed, 173 deletions(-) > delete mode 100644 drivers/staging/rtl8723bs/hal/odm_NoiseMonitor.c > delete mode 100644 drivers/staging/rtl8723bs/hal/odm_NoiseMonitor.h >