Fix indentation issue to adhere to Linux kernel coding style, Issue found by checkpatch. Change the long for loop into 3 lines. And optimize by avoiding the multiplication. Signed-off-by: Binyi Han <dantengknight@xxxxxxxxx> --- v2: - Change the long for loop into 3 lines. v3: - Align page_entries in the for loop to open parenthesis. - Optimize by avoiding the multiplication. drivers/staging/qlge/qlge_main.c | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c index 1a378330d775..4b166c66cfc5 100644 --- a/drivers/staging/qlge/qlge_main.c +++ b/drivers/staging/qlge/qlge_main.c @@ -3007,10 +3007,12 @@ static int qlge_start_rx_ring(struct qlge_adapter *qdev, struct rx_ring *rx_ring tmp = (u64)rx_ring->lbq.base_dma; base_indirect_ptr = rx_ring->lbq.base_indirect; - for (page_entries = 0; page_entries < - MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); page_entries++) - base_indirect_ptr[page_entries] = - cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE)); + for (page_entries = 0; + page_entries < MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); + page_entries++) { + base_indirect_ptr[page_entries] = cpu_to_le64(tmp); + tmp += DB_PAGE_SIZE; + } cqicb->lbq_addr = cpu_to_le64(rx_ring->lbq.base_indirect_dma); cqicb->lbq_buf_size = cpu_to_le16(QLGE_FIT16(qdev->lbq_buf_size)); @@ -3022,10 +3024,12 @@ static int qlge_start_rx_ring(struct qlge_adapter *qdev, struct rx_ring *rx_ring tmp = (u64)rx_ring->sbq.base_dma; base_indirect_ptr = rx_ring->sbq.base_indirect; - for (page_entries = 0; page_entries < - MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); page_entries++) - base_indirect_ptr[page_entries] = - cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE)); + for (page_entries = 0; + page_entries < MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); + page_entries++) { + base_indirect_ptr[page_entries] = cpu_to_le64(tmp); + tmp += DB_PAGE_SIZE; + } cqicb->sbq_addr = cpu_to_le64(rx_ring->sbq.base_indirect_dma); cqicb->sbq_buf_size = cpu_to_le16(SMALL_BUFFER_SIZE); -- 2.25.1