Re: [PATCH] staging: vchiq_arm: change vchiq_platform_init from global to static

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 4/22/22 7:44 AM, Dan Carpenter wrote:
On Mon, Apr 18, 2022 at 12:43:56PM -0400, Tom Rix wrote:
Smatch reports this issue
vchiq_arm.c:466:5: warning: symbol 'vchiq_platform_init'
   was not declared. Should it be static?
This is a Sparse warning, not Smatch.

Yes, this is correct.

Though I am using

make CC=cgcc

And forgot which one I had installed last.

Tom


Use this command for Smatch
~/smatch/smatch_scripts/kchecker drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c

And this command for Sparse
~/smatch/smatch_scripts/kchecker --sparse drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c

regards,
dan carpenter






[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux